Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room type in edit room panel is inverted #17851

Closed
cking-vonix opened this issue Jun 8, 2020 · 1 comment
Closed

Room type in edit room panel is inverted #17851

cking-vonix opened this issue Jun 8, 2020 · 1 comment

Comments

@cking-vonix
Copy link
Contributor

Description:

When administering rooms the radio buttons for room type of public / private are inverted.

Steps to reproduce:

With a fresh default install:

  1. Open Administration

  2. Click Rooms

  3. Click on General

  4. Notice the "Private" radio button is checked

Server Setup Information:

  • Version of Rocket.Chat Server: 3.3.0
  • Operating System: Ubuntu 20.04
  • Deployment Method: docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: rs0
  • NodeJS Version: 12.16.1
  • MongoDB Version: 4.2.5

Client Setup Information

  • Desktop App or Browser Version: Firefox
  • Operating System: Ubuntu 20.04
cking-vonix added a commit to cking-vonix/Rocket.Chat that referenced this issue Jun 8, 2020
@cking-vonix
[FIX] Logic for room type was inverted in edit panel (RocketChat#17851)
6604996
@cking-vonix cking-vonix mentioned this issue Jun 8, 2020
Merged
12 tasks
ggazzo pushed a commit that referenced this issue Jun 9, 2020
@cking-vonix
[FIX] Logic for room type was inverted in edit panel (#17851) (#17853)
7d1ea63
ggazzo added a commit that referenced this issue Jun 9, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
859a782 
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Importers progress sending too much update events to clients (#17857)
  [FIX] Omnichannel message link is broken in email notifications (#17843)
  [FIX] Logic for room type was inverted in edit panel (#17851) (#17853)
  Refactor components and views to Storybook compatibility (#17800)
  [FIX] Slack importer settings object (#17776)
  Create codeql-analysis.yml
@ggazzo
Copy link
Member

ggazzo commented Jun 10, 2020

closed by #17853

@ggazzo ggazzo closed this as completed Jun 10, 2020
@sampaiodiego sampaiodiego mentioned this issue Jun 10, 2020
Merged
sampaiodiego pushed a commit that referenced this issue Jun 10, 2020
@cking-vonix @sampaiodiego
[FIX] Logic for room type was inverted in edit panel (#17851) (#17853)
4adb676
ggazzo added a commit that referenced this issue Jun 17, 2020
@ggazzo
Merge branch 'threads-alpha' of github.com:RocketChat/Rocket.Chat int…
6693157 
…o threads-alpha

* 'threads-alpha' of github.com:RocketChat/Rocket.Chat: (23 commits)
  [IMPROVE][Performance] Add new database indexes to improve data query performance (#17839)
  [FIX] Undesirable message updates after user saving profile (#17930)
  Remove unused accounts-js integration (#17921)
  [IMPROVE] Don't send emails to online users and remove delay when away/idle (#17907)
  [IMPROVE] Split NOTIFICATIONS_SCHEDULE_DELAY into three separate variables (#17669)
  correct outdated dev start info
  [IMPROVE] Rewrite Federation Dashboard (#17900)
  [FIX] Duplicated placeholderaceholder  (#17898)
  Wrap components with React.memo (#17899)
  [FIX] Some Login Buttons disappear after refreshing OAuth Services (#17808)
  Change some components' location (#17893)
  [IMPROVE] Rewrite admin sidebar in React (#17801)
  Always initialize CIRCLE_BRANCH env var on CI (#17874)
  [NEW] Blocked Media Types setting (#17617)
  [FIX] Reorder hljs (#17854)
  [FIX] SAML LogoutRequest sending wrong NameID (#17860)
  [FIX] Apps room events losing data (#17827)
  [FIX] Importers progress sending too much update events to clients (#17857)
  [FIX] Omnichannel message link is broken in email notifications (#17843)
  [FIX] Logic for room type was inverted in edit panel (#17851) (#17853)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ggazzo @cking-vonix