Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hubot is breaks with rocket: 3.8.0 #19567

Closed
ataraxus opened this issue Nov 17, 2020 · 0 comments · Fixed by #20801
Closed

Hubot is breaks with rocket: 3.8.0 #19567

ataraxus opened this issue Nov 17, 2020 · 0 comments · Fixed by #20801

Comments

@ataraxus
Copy link

Description:

Hubot of us crashes when receiving message, worked from 2.x up until 3.8.0

Steps to reproduce:

Subscribe to channel
receive message

Expected behavior:

no crash

Actual behavior:

Crashes

Server Setup Information:

  • Version of Rocket.Chat Server:
  • Operating System:
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:

Client Setup Information

  • Desktop App or Browser Version: Hubot 3
  • Operating System: Raspbian

Additional context

the issue is, that the SDK Driver receives an array of messages instead an object.

offending line:
https://github.com/RocketChat/Rocket.Chat.js.SDK/blob/e507e86faf049751218a08f6488545ec77d33309/src/lib/driver.ts#L397

quick fix, add line 352:
message=message[0];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant