[FIX] Message payload from __my_messages__ stream
#20801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
approved these changes
Feb 18, 2021
sampaiodiego
changed the title
__my_messages__ stream
sampaiodiego
changed the title
__my_messages__ stream__my_messages__ stream
sampaiodiego
pushed a commit
that referenced
this pull request
Feb 19, 2021
Merged
jsbronder
added a commit
to jsbronder/wcrc
that referenced
this pull request
Mar 4, 2021
Workaround RocketChat/Rocket.Chat#20801. Which is to say, upstream made this a list by mistake in 3.8.0, still hasn't fixed it after 8 point releases and no one can actually determine if its a bug or not because there's no documentation telling you what to expect from this stream. But in 3.12.0, it's reverted, so we need to handle both.
jsundahl
added a commit
to jsundahl/skyfall-plugin-rocketchat
that referenced
this pull request
Jul 20, 2021
rocketchat is dumb and sends an array of one message since version 3.8.0. see RocketChat/Rocket.Chat#20801 this is scheduled to be fixed in version 3.12.0
mdbarr
pushed a commit
to mdbarr/skyfall-plugin-rocketchat
that referenced
this pull request
Jul 20, 2021
rocketchat is dumb and sends an array of one message since version 3.8.0. see RocketChat/Rocket.Chat#20801 this is scheduled to be fixed in version 3.12.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19566
closes #19567
closes #19433
closes RocketChat/Rocket.Chat.js.SDK#121
closes RocketChat/Rocket.Chat.js.SDK#126
closes RocketChat/Rocket.Chat.js.SDK#127
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments