The new message template cannot resolve pointer usernames that contain @ character

[Gummikavalier]

Description:

The new message template cannot "resolve" user names in the message pointers should they contain @ character in the target's username.

Especially the systems that use emails as their main username attribute suffer from the issue. Also those Oauth enabled instances that get the user names in format such as username@example.com.

In this issue example the username is called 099fnd2ee@example.com. The real name is Test Account.

Steps to reproduce:

1. Set RC to user real names by default under Layout -> User Interface -> Use Real Name
2. Create account with username that contains @ character. Set the name and email separately to something else.
3. Send a message to the user that has @ character in their username

Expected behavior:

The pointer string should show the real name (Test Account) and also have it highlighted.

Actual behavior:

The username is shown instead of the real name and it is not highlighted.

Server Setup Information:

• Version of Rocket.Chat Server: 5.1.2
• Operating System: RHEL8
• Deployment Method: tar
• Number of Running Instances: 10
• DB Replicaset Oplog: Yes
• NodeJS Version: 14.19.3
• MongoDB Version: 4.4

Client Setup Information

• Desktop App or Browser Version: Any browser

[hugocostadev]

Hi @Gummikavalier , thanks for your concern.

Let me ask you a question, do you even got it to create a username with an email pattern?
When I tried to replicate this issue I got an error:

[Gummikavalier]

@hugocostadev Yes. In our case the usernames get created by Oauth provisioning and we also have allowed @ character in the UTF-8 slugify options. Like this:

Admin -> General -> UTF8

On both validation fields string: [0-9a-zA-Z-_.@-]+

UTF8 Names Slugify 'on'

Sorry that I forgot to add that into the original issue.

[hugocostadev]

Got it @Gummikavalier ! Thank you for your feedback, I'll address this issue internally!

[Gummikavalier]

Confirmed working on RC 5.4.0. ❤️