Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message-parser): User mention with @ character #894

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Nov 8, 2022

Proposed changes (including videos or screenshots)

Enable the possibility to handle user mentions with @ characters and highlight them

After writing @username@example.com in the message box it's given:

With and without Real Name display:
thumb-Clipboard - November 8, 2022 10_08 AM
thumb-Clipboard - November 8, 2022 10_08 AM (1)

Issue(s)

RocketChat/Rocket.Chat#26869

Further comments

TC-254

@dougfabris dougfabris changed the title fix: User mention with @ character fix(message-parser): User mention with @ character Nov 8, 2022
@gabriellsh gabriellsh marked this pull request as draft November 8, 2022 19:34
@hugocostadev hugocostadev marked this pull request as ready for review November 9, 2022 17:13
@gabriellsh gabriellsh merged commit aa9bc06 into develop Nov 10, 2022
@gabriellsh gabriellsh deleted the fix/mentions branch November 10, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants