Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to a third-level domain with a dash are not active #27376

Closed
shevchukma opened this issue Nov 28, 2022 · 7 comments · Fixed by #27947
Closed

Links to a third-level domain with a dash are not active #27376

shevchukma opened this issue Nov 28, 2022 · 7 comments · Fixed by #27947
Assignees

Comments

@shevchukma
Copy link

Description:

In the new message template, links do not become clickable if there is a third-level domain in the address, while a dash is present in the second-level domain.

Steps to reproduce:

  1. Send to chat link http://test.e-xample.com
  2. The link does not become active.

Expected behavior:

Links with dashes are converted to clickable links.

Actual behavior:

Links to a third-level domain with a dash are not converted to active.
image

Server Setup Information:

  • Version of Rocket.Chat Server: 5.3.3
  • Operating System: Oracle Linux 8.5
  • Deployment Method: docker
  • Number of Running Instances: 20
  • DB Replicaset Oplog: Enabled
  • NodeJS Version: v14.19.3
  • MongoDB Version: 5.0.14

Client Setup Information

  • Desktop App or Browser Version: Desktop App 3.8.11
  • Operating System: Windows 10
@matthias4217
Copy link
Contributor

I can confirm what's been said, on Rocket Chat 5.3.3. However, I'd like to add that https://test.ex-ample.com works fine.

@dudanogueira
Copy link
Contributor

Related issue: #27078

@ggazzo ggazzo removed the ui/ux label Nov 29, 2022
@david-m-m
Copy link

Seems like links with a 2nd level domain starting with a number are also affected:

  • [Test Link](https://www.1forall.com) is not rendered correctly
  • [Test Link2](https://www.one-forall.com) is rendered as a link

@ebyrne242
Copy link

Also on 5.3.3. Possibly worth noting this happens even if you try to use markdown to get around it (includes "edit mode" of last link to show markdown)

image

Also, this is specific to the new message parser. It renders correctly with the legacy if I switch to the message template:

image

@frankMagoba
Copy link

Cause of bug is an external lib @rocket.chat/message-parser that is responsible for detecting links in messages and the changes needed to resolve this need to be made on some other different repo here

@grape9292
Copy link

grape9292 commented Dec 23, 2022

Have the same issue in RocketChat 5.4.1. Links like test.1test.com and test.t-est.com aren't clickable in a chat message.

@hugocostadev hugocostadev self-assigned this Jan 23, 2023
@hugocostadev
Copy link
Contributor

Hi, @shevchukma I'm working on this issue! Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants