Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Message-parser link issues #27947

Merged
merged 7 commits into from
Feb 8, 2023
Merged

[FIX] Message-parser link issues #27947

merged 7 commits into from
Feb 8, 2023

Conversation

hugocostadev
Copy link
Contributor

Proposed changes (including videos or screenshots)

The changes were made in the fuselage repository. This PR just update the message-parser package version
Check the changes in this PR:
RocketChat/fuselage#962

Issue(s)

fix #27376
fix #27484
fix #26476
fix #27078
fix #27890

Steps to test or reproduce

Further comments

TC-294

@hugocostadev hugocostadev added this to the 6.0.0 milestone Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #27947 (5d2229d) into develop (d13110f) will increase coverage by 0.97%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27947      +/-   ##
===========================================
+ Coverage    42.14%   43.12%   +0.97%     
===========================================
  Files          848      821      -27     
  Lines        17555    17038     -517     
  Branches      2078     2003      -75     
===========================================
- Hits          7399     7347      -52     
+ Misses        9875     9410     -465     
  Partials       281      281              
Flag Coverage Δ
e2e 43.12% <ø> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 6, 2023
@rodrigok
Copy link
Member

rodrigok commented Feb 7, 2023

@hugocostadev not sure what is going on but it's not building at all

@hugocostadev
Copy link
Contributor Author

@hugocostadev not sure what is going on but it's not building at all

It's a flack test, I'll update with the develop to see how it goes

@rodrigok
Copy link
Member

rodrigok commented Feb 8, 2023

@hugocostadev can you solve the flack test? I never saw a flaky test on unit tests

@kodiakhq kodiakhq bot merged commit 6e4db21 into develop Feb 8, 2023
@kodiakhq kodiakhq bot deleted the fix/link-issues branch February 8, 2023 19:17
@Matt-something
Copy link

Links where the toplevel domain doesn't include a full stop are still broken, see 27981

@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
@MarlynxLinux
Copy link

MarlynxLinux commented Nov 8, 2023

Version 6.4.5
Links are displayed incorrectly:
[test1](http://rocket.chat?text=(some_argument))

Снимок экрана от 2023-11-08 10-33-37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment