Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something went wrong with error alert is showing instead of "no results found" in custom sound #29175

Closed
wave-nature opened this issue May 8, 2023 · 2 comments · Fixed by #28302

Comments

@wave-nature
Copy link

wave-nature commented May 8, 2023

Description:

If there is no custom sounds, it supposed to show no results, but here it is showing something went wrong with alert error message of "no results found" (looks like vice versa). Although I checked in network tab status is 200 and sounds is empty array.

Steps to reproduce:

  1. Go to admin panel side bar
  2. Click on custom sounds
  3. Here you can see the bug if there is no custom sounds

Expected behavior:

It should show the message no results found if there is no custom sounds

Actual behavior:

image

But in production it is showing error message of something went wrong even though there is no custom sounds

Server Setup Information:

  • Version of Rocket.Chat Server:
  • Operating System:
  • Deployment Method:
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • NodeJS Version:
  • MongoDB Version:

Client Setup Information

  • Desktop App or Browser Version:
  • Operating System:

Additional context

Relevant logs:

@wave-nature
Copy link
Author

I request to work on this issue and solve this ASAP. Please allow me!

@dougfabris
Copy link
Member

dougfabris commented May 16, 2023

Hey @wave-nature this issue was fixed here: #28302 and release on our latest 6.2 version.
Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants