fix: Error message is displayed in case no file is found in custom sound section. #28302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om sound section.Also fixed search bar issue in case of no result found
bhardwajdisha
changed the title
bhardwajdisha
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #28302 +/- ##
==========================================
Coverage ? 45.12%
==========================================
Files ? 755
Lines ? 14607
Branches ? 2085
==========================================
Hits ? 6592
Misses ? 7718
Partials ? 297
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@hugocostadev & @ggazzo can you please review this |
hugocostadev
approved these changes
Mar 15, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
dougfabris
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixed issue: Error message is displayed in case no file is found in custom sound section.
Also fixed search bar issue which used to get hidden in case no file is found in custom sound section.
To fix the issue
Changes made in apps/meteor/client/views/admin/customSounds/CustomSoundsRoute.tsx and checked it on my local environment and it works fine. Please review this.
No.file.found.issue-custom.sound.-.Made.with.Clipchamp.mp4
Issue(s)
closes #28296
closes #29175
Steps to test or reproduce
Further comments