Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add personal preference for 12/24h time #2922

Closed
toupeira opened this issue Apr 17, 2016 · 13 comments
Closed

Add personal preference for 12/24h time #2922

toupeira opened this issue Apr 17, 2016 · 13 comments

Comments

@toupeira
Copy link

My Rocket.Chat version: 0.26.0

From what I gather (#1959, #1960) the time format depends on the moment.js locale, which depends on the Rocket.Chat UI language. The thing is, I'd like to use English but also 24h format since I live in Europe, one way to offer that would be to expose the en-* locales from moment.js so I can just use en-gb to get 24h times. Another option might be to have a dedicated setting for the time formatting.

@engelgabriel
Copy link
Member

Have you seen this PR #2852 ?

@toupeira
Copy link
Author

I did not, thanks! That looks like it solves my issue. Though if that's only an admin-level setting, you still might want to consider adding it as a user option or adding the missing locales, for servers with an international userbase.

@ma-karai
Copy link

HH:mm:ss

@evgeni
Copy link

evgeni commented Oct 4, 2016

Ohai,

I think #2852 is not really a solution here. We're running Rocket.Chat for a worldwide org, and the users tend to prefer different 12/24h clock settings (while still using English instead of $Local_Lang).

I think ultimately time-preferences should not be coupled to language preferences. It might be a good default, but the user should be able to override this.

My 0.02€

@toupeira
Copy link
Author

toupeira commented Oct 5, 2016

Actually I agree with @evgeni, it's just less of an issue for me because I don't have international users. But the point is valid, so I reopened the issue.

@toupeira toupeira reopened this Oct 5, 2016
@Artoria2e5
Copy link

A +1 on this. 12/24h time can often be a personal preference thing as opposed to a locale-dependent one.

@baurmatt
Copy link

baurmatt commented Jan 9, 2018

Yes, please! :)

@toupeira toupeira changed the title Support 24h time format in English locale Add personal preference for 12/24h time Jan 9, 2018
@baynes
Copy link

baynes commented Mar 14, 2018

+1 from me. I am English (UK) but want 24 hour clock.

@cypa
Copy link

cypa commented May 11, 2018

+1

@engelgabriel
Copy link
Member

We are accepting PRs to turn this into a personal setting.

@engelgabriel engelgabriel added contrib: easy Feature: Planned Planned Feature and removed Feature: Request Requested Feature labels Jun 7, 2018
@engelgabriel engelgabriel added this to the Long-term milestone Jun 7, 2018
@ma-karai
Copy link

ma-karai commented Jun 7, 2018

While you guys are at it, I am sure it would be greatly appreciated if a user could customize the order of entities of messages.

Right now its:
[avatar] [name] [time] [msg]

It would be great if users could change the arrangement.
I personally prefer

[time] [avatar] [name] [msg]

I am sure other people would like to do

[time] [name] [msg]

ggazzo pushed a commit that referenced this issue Sep 19, 2018
Closes #2922
Closes #4706

This PR adds a personal preference for what timestamp format to use:
![2018-06-16_21-26-48](https://user-images.githubusercontent.com/39674991/41501824-ffb5f034-71ab-11e8-813e-8a2c724fc84b.png)

**Default** uses the timestamp formats (usually `LT` and `LLL`) defined in admin settings.
**12-hour** uses a 12-hour format (`6:30 PM` or `January 3, 2018 6:30 PM`)
**24-hour** uses a 24-hour format (`18:30` or `January 3, 2018 18:30`)
@theorenck theorenck removed this from the Long-term milestone Dec 12, 2018
@gyde
Copy link

gyde commented Nov 7, 2019

Where is this feature now, can't see it anywhere under the "My Account -> Preferences"?

@leonschoorl
Copy link

It's at: My Account -> Preferences -> Messages -> Time Format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests