Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual clue / button to exit edit mode. #575

Closed
geekgonecrazy opened this issue Aug 25, 2015 · 9 comments
Closed

Visual clue / button to exit edit mode. #575

geekgonecrazy opened this issue Aug 25, 2015 · 9 comments
Assignees
Milestone

Comments

@geekgonecrazy
Copy link
Contributor

There currently is no indicator of how to exit / cancel edit. Hitting escape exits... But there should be a visual way to do this. Somewhere to just click and cancel the edit.

@rockneverdies55
Copy link

+1

@Sing-Li
Copy link
Member

Sing-Li commented Aug 25, 2015

Aha! Hitting escape?! And I've been begging people to forgive my double, triple, quadruple posts 😄

How do you do it on android or iphone? 😕

@geekgonecrazy
Copy link
Contributor Author

@Sing-Li yeah I don't know if escape is being bound to the cancel or if its coincidental.

You don't exit on mobile currently. ;-) Editing on mobile is currently broken also: #552

@Sing-Li
Copy link
Member

Sing-Li commented Aug 25, 2015

But up until very recently, I've been able to edit in place - right where the message is displayed; and it even worked on mobile. Hmm.... mmmm ..... mmm...
..mmm..... awaiting enlightenment from UI gurus.

@geekgonecrazy
Copy link
Contributor Author

I know that is the way slack works. If done right, editing on the bottom could be pretty sweet.

Kinda cool being able to just hit the up arrow to get to your last message and update it. Even though I hit the up arrow out of habit to get last command so I can repeat it 😄

@rodrigok
Copy link
Member

I totally agree with buttons to cancel and commit edition.

Slack also keep the editing at bottom in mobile, so we think this is the better way, keep the same behavior in all devices.

Navigate among history is a good ideia, maybe we can create another shortcut like CMD/CTRL + UP/DOWN.

@rockneverdies55
Copy link

Pressing ESC key doesn't cancel edit for me on window 7 machine with chrome browser version 43.0.2357.134 m.

However, when I click esc to cancel link at the bottom of text box, it works.

I didn't know if I should re-open this one or create a new issue?

@rodrigok
Copy link
Member

@rockneverdies55 Please open a new issue, seems to be more related with Windows.

@stuartpb
Copy link
Contributor

for posterity, the above issue was opened as #603

Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this issue Apr 4, 2019
…ocketChat#575)

* Fix highlight in markdown rendered texts and multiline translations

* Remove unneccessary find-before-replace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants