E-Mail message forward throws exception #6179

rasos · 2017-02-27T12:50:39Z

When selecting a message to be forwarded, the subject line contains an "undefined":
Hier ist ein ausgewählter Teil aus undefined Nachrichten

When pressing the Send button, an internal server error is reported to the user. Seems to be related to localisation (ours is "Deutsch" - German, which has a pretty completed translation set). Here is the log:

Sending messages to e-mails:  [ 'a344r.rer1234@domain.com' ] 
�[34mI20170227-13:39:30.578(1) Exception while invoking method 'mailMessages' TypeError: Cannot read property 'defineLocale' of undefined   at eval (<anonymous>:30:20)   at format.m (<anonymous>:12:4)   at eval (<anonymous>:13:2)   at [object Object].mailMessages (/var/lib/rocket.chat/bundle/programs/server/packages/rocketchat_channel-settings-mail-messages.js:119:29)   at [object Object].methodsMap.(anonymous function) (/var/lib/rocket.chat/bundle/programs/server/packages/rocketchat_lib.js:1064:26)   at maybeAuditArgumentChecks (/var/lib/rocket.chat/bundle/programs/server/packages/ddp-server.js:2108:12)   at /var/lib/rocket.chat/bundle/programs/server/packages/ddp-server.js:1042:22   at [object Object]._.extend.withValue (packages/meteor.js:1122:17)   at /var/lib/rocket.chat/bundle/programs/server/packages/ddp-server.js:1041:43   at [object Object]._.extend.withValue (packages/meteor.js:1122:17)   at /var/lib/rocket.chat/bundle/programs/server/packages/ddp-server.js:1040:48   at Session.method (/var/lib/rocket.chat/bundle/programs/server/packages/ddp-server.js:1018:23)   at /var/lib/rocket.chat/bundle/programs/server/packages/ddp-server.js:880:89

Rocket.Chat Version: 0.52
Running Instances: 1

The text was updated successfully, but these errors were encountered:

rasos · 2017-03-02T08:24:10Z

Please check when refactoring E-Mail in #6196 .
Will check for MAIL_URL #3602 .

TheReal1604 · 2017-03-05T10:43:09Z

@rasos Got the same issue on my 3 server setup. (but only on locale = german systems) Version: 0.53.0

Exception while invoking method 'mailMessages' TypeError: Cannot read property 'defineLocale' of undefined   at eval (<anonymous>:30:20)   at format.m (<anonymous>:12:4)   at eval (<anonymous>:13:2)   at [object Object].Meteor.methods.mailMessages (packages/rocketchat_channel-settings-mail-messages.js:135:27)   at [object Object].methodsMap.(anonymous function) (/app/bundle/programs/server/packages/rocketchat_lib.js:1093:26)   at maybeAuditArgumentChecks (/app/bundle/programs/server/packages/ddp-server.js:1817:12)   at /app/bundle/programs/server/packages/ddp-server.js:905:20   at [object Object]._.extend.withValue (packages/meteor.js:1122:17)   at /app/bundle/programs/server/packages/ddp-server.js:904:41   at [object Object]._.extend.withValue (packages/meteor.js:1122:17)   at /app/bundle/programs/server/packages/ddp-server.js:903:46   at [object Object]._.extend.protocol_handlers.method (/app/bundle/programs/server/packages/ddp-server.js:876:21)   at /app/bundle/programs/server/packages/ddp-server.js:755:85

localguru · 2017-05-30T08:41:18Z

see this on 0.56.0 too, german locale de_DE.UTF-8

Jun 13 20:22:56 devserv rocketchat[968]: #033[34mMeteor ➔ method#033[39m mailMessages -> userId: suRn6iLpamCiC6mWK , arguments:  { '0':
Jun 13 20:22:56 devserv rocketchat[968]:    { rid: 'DX4TYHhdeMEwPisdk',
Jun 13 20:22:56 devserv rocketchat[968]:      to_users: [],
Jun 13 20:22:56 devserv rocketchat[968]:      to_emails: 'xxxx@domain.de',
Jun 13 20:22:56 devserv rocketchat[968]:      subject: 'Hier ist ein ausgewählter Teil aus foo Nachrichten',
Jun 13 20:22:56 devserv rocketchat[968]:      messages: [ 'awasgFyQGE4pj6B5m', 'JQzmYxNp442SyaQTo' ],
Jun 13 20:22:56 devserv rocketchat[968]:      language: 'de' } }
Jun 13 20:22:56 devserv rocketchat[968]: #033[34mMeteor ➔ method#033[39m canAccessRoom -> userId: suRn6iLpamCiC6mWK , arguments:  { '0': 'DX4TYHhdeMEwPisdk', '1': 'suRn6iLpamCiC6mWK' }
Jun 13 20:22:56 devserv rocketchat[968]: Sending messages to e-mails:  [ 'xxxx@domain.de' ]
Jun 13 20:22:56 devserv rocketchat[968]: #033[34mMeteor ➔ method#033[39m loadLocale -> userId: suRn6iLpamCiC6mWK , arguments:  { '0': 'de' }
Jun 13 20:22:56 devserv rocketchat[968]: Exception while invoking method 'mailMessages' TypeError: Cannot read property 'defineLocale' of undefined
Jun 13 20:22:56 devserv rocketchat[968]:   at eval (<anonymous>:30:20)
Jun 13 20:22:56 devserv rocketchat[968]:   at format.m (<anonymous>:12:4)
Jun 13 20:22:56 devserv rocketchat[968]:   at eval (<anonymous>:13:2)
Jun 13 20:22:56 devserv rocketchat[968]:   at [object Object].Meteor.methods.mailMessages (/opt/rocketchat/Rocket.Chat/programs/server/packages/rocketchat_channel-settings-mail-messages.js:125:23)
Jun 13 20:22:56 devserv rocketchat[968]:   at [object Object].methodsMap.(anonymous function) (/opt/rocketchat/Rocket.Chat/programs/server/packages/rocketchat_lib.js:1021:26)
Jun 13 20:22:56 devserv rocketchat[968]:   at [object Object].methodMap.(anonymous function) (packages/rocketchat_monitoring.js:2731:30)
Jun 13 20:22:56 devserv rocketchat[968]:   at maybeAuditArgumentChecks (/opt/rocketchat/Rocket.Chat/programs/server/packages/ddp-server.js:1823:12)
Jun 13 20:22:56 devserv rocketchat[968]:   at /opt/rocketchat/Rocket.Chat/programs/server/packages/ddp-server.js:905:20
Jun 13 20:22:56 devserv rocketchat[968]:   at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
Jun 13 20:22:56 devserv rocketchat[968]:   at /opt/rocketchat/Rocket.Chat/programs/server/packages/ddp-server.js:904:41
Jun 13 20:22:56 devserv rocketchat[968]:   at [object Object]._.extend.withValue (packages/meteor.js:1122:17)
Jun 13 20:22:56 devserv rocketchat[968]:   at /opt/rocketchat/Rocket.Chat/programs/server/packages/ddp-server.js:903:46
Jun 13 20:22:56 devserv rocketchat[968]:   at [object Object]._.extend.protocol_handlers.method (/opt/rocketchat/Rocket.Chat/programs/server/packages/ddp-server.js:876:21)
Jun 13 20:22:56 devserv rocketchat[968]:   at /opt/rocketchat/Rocket.Chat/programs/server/packages/ddp-server.js:755:85

localguru · 2017-05-30T12:55:02Z

If Account locale is set from German to English, sending emails is working. Hmmm .... The error is somewhere in rocketchat_channel-settings-mail-messages.js line 119:

      if (data.language !== 'en') {
        localeFn = Meteor.call('loadLocale', data.language);
        if (localeFn) {
          Function(localeFn)();
        }
      }

If I change data.language !== 'en' to data.language !== 'de then it's working in DE and not in EN.

I'm not 100% sure, but I think it has to change to

      if (data.language !== 'en') {
        localeFn = Meteor.call('loadLocale', data.language);
        if (localeFn) {
          Function(moment.localeFn)();
        }
      }

With Function(moment.localeFn)(); mails are sent out. Could someone check that please.

approximatenumber · 2017-06-14T10:29:04Z

Same Issue.
Rocket.Chat 0.56.0
LANG=ru_RU.utf-8

Changing in rocketchat_channel-settings-mail-messages.js:
Function(localeFn)(); -> Function(moment.localeFn)(); helps. Thanks @localguru
But I don`t code on js, so I don`t know is it correct edit?..

See RocketChat#6179 (comment)

localguru · 2017-06-24T09:29:49Z

My above code doesn't throw an error, but it seems not to be the solution, see #7245

sampaiodiego · 2017-07-03T14:19:09Z

duplicated of #5797

localguru · 2017-09-08T21:12:13Z

Please reopen, #7846 doesn't fix it

sampaiodiego · 2017-09-25T16:40:13Z

thanks @localguru .. tested on develop and yes it is still hapenning

TheReal1604 · 2017-10-16T13:50:31Z

@sampaiodiego have you some news on this? a really bad bug - which makes this feature unusable for many users. :(

Closes #6179

MartinSchoeler added feat: email type: support labels Mar 1, 2017

localguru mentioned this issue May 30, 2017

Server error when i will sending selected messages by email #6402

Closed

localguru mentioned this issue May 30, 2017

Cannot send chat messages via email #5797

Closed

localguru mentioned this issue Jun 13, 2017

[FIX] email message forward fix #7245

Closed

rasos added a commit to rasos/Rocket.Chat that referenced this issue Jun 14, 2017

Fix i18n issue

9492660

See RocketChat#6179 (comment)

rasos mentioned this issue Jun 14, 2017

Fix i18n issue with forwarding messages as E-Mails #7252

Closed

sampaiodiego closed this as completed Jul 3, 2017

engelgabriel added this to the 0.58.0 milestone Jul 4, 2017

rodrigok mentioned this issue Aug 23, 2017

[FIX] Email message forward error #7846

Merged

sampaiodiego reopened this Sep 25, 2017

sampaiodiego added type: bug and removed type: support labels Sep 25, 2017

sampaiodiego added a commit that referenced this issue Oct 25, 2017

[FIX] Fix e-mail message forward

308d937

Closes #6179

sampaiodiego mentioned this issue Oct 25, 2017

[FIX] Fix e-mail message forward #8645

Merged

rodrigok closed this as completed in #8645 Oct 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

E-Mail message forward throws exception #6179

E-Mail message forward throws exception #6179

rasos commented Feb 27, 2017

rasos commented Mar 2, 2017

TheReal1604 commented Mar 5, 2017 •

edited

Loading

localguru commented May 30, 2017 •

edited

Loading

localguru commented May 30, 2017 •

edited

Loading

approximatenumber commented Jun 14, 2017 •

edited

Loading

localguru commented Jun 24, 2017

sampaiodiego commented Jul 3, 2017

localguru commented Sep 8, 2017

sampaiodiego commented Sep 25, 2017

TheReal1604 commented Oct 16, 2017

E-Mail message forward throws exception #6179

E-Mail message forward throws exception #6179

Comments

rasos commented Feb 27, 2017

rasos commented Mar 2, 2017

TheReal1604 commented Mar 5, 2017 • edited Loading

localguru commented May 30, 2017 • edited Loading

localguru commented May 30, 2017 • edited Loading

approximatenumber commented Jun 14, 2017 • edited Loading

localguru commented Jun 24, 2017

sampaiodiego commented Jul 3, 2017

localguru commented Sep 8, 2017

sampaiodiego commented Sep 25, 2017

TheReal1604 commented Oct 16, 2017

TheReal1604 commented Mar 5, 2017 •

edited

Loading

localguru commented May 30, 2017 •

edited

Loading

localguru commented May 30, 2017 •

edited

Loading

approximatenumber commented Jun 14, 2017 •

edited

Loading