Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack import fails when encountering file upload #7447

Closed
zw42 opened this issue Jul 7, 2017 · 3 comments · Fixed by #7469
Closed

Slack import fails when encountering file upload #7447

zw42 opened this issue Jul 7, 2017 · 3 comments · Fixed by #7469

Comments

@zw42
Copy link

zw42 commented Jul 7, 2017

Rocket.Chat Version: 0.57.1 (Ubuntu snap)
Running Instances: 1
DB Replicaset OpLog: Enabled
Node Version: v4.8.1

Have an issue when importing from Slack: causes an exception when it needs to upload a file. From the log:

snap[9263]: Exception in defer callback: TypeError: Cannot read property 'get' of undefined snap[9263]: at _class.uploadFile (/snap/rocketchat-server/812/programs/server/packages/rocketchat_importer.js:325:24) snap[9263]: at /snap/rocketchat-server/812/programs/server/packages/rocketchat_importer-slack.js:555:20 snap[9263]: at Array.forEach (native) snap[9263]: at /snap/rocketchat-server/812/programs/server/packages/rocketchat_importer-slack.js:458:22 snap[9263]: at Array.forEach (native) snap[9263]: at [object Object].<anonymous> (/snap/rocketchat-server/812/programs/server/packages/rocketchat_importer-slack.js:456:32) snap[9263]: at packages/dispatch_run-as-user.js:211:14 snap[9263]: at [object Object]._.extend.withValue (packages/meteor.js:1122:17) snap[9263]: at Object.Meteor.runAsUser (packages/dispatch_run-as-user.js:210:33) snap[9263]: at /snap/rocketchat-server/812/programs/server/packages/rocketchat_importer-slack.js:442:13 snap[9263]: at Array.forEach (native) snap[9263]: at /snap/rocketchat-server/812/programs/server/packages/rocketchat_importer-slack.js:440:34 snap[9263]: at [object Object]._.extend.withValue (packages/meteor.js:1122:17) snap[9263]: at packages/meteor.js:445:45

This issue was not present in 0.56.0 (using the same Slack import file).

@graywolf336
Copy link
Contributor

@sampaiodiego @rodrigok this is broke because of the change to file uploads.

@sampaiodiego
Copy link
Member

@graywolf336 yes, it looks like.

@zw42 what file upload storage are you using?

@zw42
Copy link
Author

zw42 commented Jul 7, 2017

@sampaiodiego using GridFS, also tried FileSystem but the same issue persisted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants