Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload of application/zip file with non-".zip" extension leads to JS error #7462

Closed
TwizzyDizzy opened this issue Jul 10, 2017 · 0 comments · Fixed by #7623
Closed

Upload of application/zip file with non-".zip" extension leads to JS error #7462

TwizzyDizzy opened this issue Jul 10, 2017 · 0 comments · Fixed by #7623

Comments

@TwizzyDizzy
Copy link

Rocket.Chat Version: 0.57.1 + 0.56.0 (tested on both, the former is the dev environment, the latter is the corresponding live environment)
Running Instances: 1
DB Replicaset OpLog: disabled
Node Version: 4.8.3

Upload of filetype .sketch fails. This seems to be a normal zip file with the extension ".sketch".

The mime-type application/zip is enabled for uploads. If the attached .sketch file (example file: Untitled.zip - rename to "notrelevant.sketch" first, before trying to upload) is uploaded (drag&drop), there is not UI feedback but the attached error in the JavaScript console.

Expected behaviour would be to tell the user "this is no valid filetype" or to show the "name this upload"-dialogue. Neither happens.

Cheers
Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants