Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing room name doesn't update incoming webhooks #8477

Closed
antgel opened this issue Oct 13, 2017 · 1 comment
Closed

Changing room name doesn't update incoming webhooks #8477

antgel opened this issue Oct 13, 2017 · 1 comment
Assignees
@Hudell
Labels
feat: webhooks type: bug

Comments

@antgel
Copy link
Contributor

antgel commented Oct 13, 2017

If I have an incoming webhook set to room #foo, then I change #foo's name to #bar, the webhooks don't get updated, and I only find out when webhooks stop working. No error is raised either, I opened #8476 for that.
@Hudell Hudell self-assigned this Jun 6, 2018
@knrt10
Copy link
Contributor

knrt10 commented Mar 10, 2019

@Hudell are you still working on it? I would like to fix this.

knrt10 added a commit to knrt10/Rocket.Chat that referenced this issue Mar 11, 2019
@knrt10
Fixes RocketChat#8477
c7c9714
@knrt10 knrt10 mentioned this issue Mar 11, 2019
Merged
knrt10 added a commit to knrt10/Rocket.Chat that referenced this issue Mar 13, 2019
@knrt10
Fixes RocketChat#8477
e92dbaa
knrt10 added a commit to knrt10/Rocket.Chat that referenced this issue Mar 14, 2019
@knrt10
Fixes RocketChat#8477
b6c16ca
sampaiodiego pushed a commit that referenced this issue Mar 14, 2019
@knrt10 @sampaiodiego
[FIX] Changing Room name updates the webhook (#13672)
d33d3cd 
* Fixes #8477

* Rebased branch

* CI fix
bhardwajaditya pushed a commit to bhardwajaditya/Rocket.Chat that referenced this issue Mar 14, 2019
@knrt10 @bhardwajaditya
[FIX] Changing Room name updates the webhook (RocketChat#13672)
4455723 
* Fixes RocketChat#8477

* Rebased branch

* CI fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hudell Hudell

Labels
feat: webhooks type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@antgel @Hudell @MartinSchoeler @knrt10