Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix spelling of "collaborative" #10134

Merged
merged 2 commits into from
Jun 7, 2018
Merged

Conversation

stuartpb
Copy link
Contributor

@RocketChat/core

Copy link

@reece8765 reece8765 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I’d approve this, but I haven really used GitHub for that long and I don’t wanna mess this project up XD

Copy link

@jack17529 jack17529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartpb Please tell what is the Issue you solved by the including issue url.

@@ -94,7 +94,7 @@
<div class="rc-user-info__row rc-user-info__row--separator">
<div class="rc-switch-double">
<div class="rc-switch-double__label {{equal true value 'disabled'}}">
{{_ "Colaborative"}}{{equal default value '*'}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartpb and this was issue number ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I really need a separate issue for a one-character spelling fix?

@geekgonecrazy
Copy link
Contributor

@RocketChat/ui I can't tell is this one translated? If so we probably need the i18n files updated?

@karlprieb
Copy link
Contributor

@geekgonecrazy yep, apparently we don't have "Collaborative" key on our i18n files. @stuartpb can you add this key?

@engelgabriel engelgabriel merged commit a0c709c into RocketChat:master Jun 7, 2018
@sampaiodiego sampaiodiego mentioned this pull request Jun 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants