[FIX] Add customFields for im.list.everyone #10180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We apologize for not getting a review on this sooner. At this point the PR is too out of sync to be able to accept and I can't see any reason to save the Users' custom fields to the DM rooms' record, it would be better to use a query aggregation to allow to filter rooms' by any custom field defined on the user. I'll close this PR for now, let us know your thoughts. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eugene Bolshakov pub@relvarsoft.com
@RocketChat/core
This PR extends PR #9424 to allow a search of customFields for
im.list.everyone. It is performed by adding customFields to Direct Messages Room model and use it withim.list.everyone.