[FIX] Livechat desktop notifications not being displayed #10221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should close #8624 as well |
sampaiodiego
approved these changes
Apr 16, 2018
sampaiodiego
changed the title
mrsimpson
pushed a commit
to assistify/Rocket.Chat
that referenced
this pull request
Apr 24, 2018
…the browser (RocketChat#10221) * Fix desktop notifications when agent has not focussed the browser. * Fix trailing spaces.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #10074
Closes #8624
This PR fixes the bug related to desktop notifications un LiveChat rooms. When a visitor was sending messages and the agent was not focused on the browser, desktop notifications were not displayed to the agent.