Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New issue template for *Release Process* #10234

Merged
merged 8 commits into from
Apr 9, 2018
Merged

New issue template for *Release Process* #10234

merged 8 commits into from
Apr 9, 2018

Conversation

rodrigok
Copy link
Member

No description provided.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10234 March 27, 2018 13:11 Inactive
geekgonecrazy
geekgonecrazy previously approved these changes Mar 27, 2018
Copy link
Contributor

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this 😍 going to make it super transparent to everyone include our own team, where we are in the process.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10234 March 27, 2018 15:12 Inactive
@kaiiiiiiiii
Copy link
Contributor

kaiiiiiiiii commented Mar 27, 2018

I totally agree with @geekgonecrazy!

And I think there's still a typo in it btw. The word "highlight" in the before release part is missing a letter :)

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10234 March 27, 2018 18:18 Inactive
@geekgonecrazy
Copy link
Contributor

@kaiiiiiiiii fixed :) I manually fixed in the issue we created for 0.63.0 also

@rodrigok rodrigok temporarily deployed to rocket-chat-pr-10234 March 27, 2018 18:26 Inactive
-->

## Final Release - On the 27th
- [ ] Merge `develop` into `release-candidate` branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sampaiodiego Explain please.. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sry, it was too late to explain 😛

so, I might not have understood correctly at the time I read. but reading it again I guess we will not merge anything to develop during freeze time? if so, this sentence is correct

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be incorrect. We will be merging bug fixes into develop. Ideally between the time of the first release candidate and the release there will be more release candidates which contain the bug fixes merged, thus when the final release happens there won't be much to merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, true, you're right.. but we'll be merging only bug fixes introduced by the release candidate in progress.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we or are we not? I honestly feel that we do not need to limit ourselves to saying we will only merge bugs introduced by the release candidate. Otherwise we will be limiting ourselves and even be questioning whether the bug was introduced in the release candidate or whether it existed before.

Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix some wording regarding our "feature freeze". Features are new additions. Bug fixes are fixes.

# Release {version}
We are releasing a new version, this issue will keep track of the progress between the first release candidate (20th of each month) to the final release (27th of each month).

After the 20th of each month we start the release process that ends 7 days after, during that period we enter a Feature Freeze. While in the Feature Freeze we do not merge new features or non critical or important bug fixes. Fixes for bugs created by this release will be prioritized.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the 20th of each month we start the release process that ends 7 days after, during that period we enter a Feature Freeze. While in the Feature Freeze, we will only be merging bug fixes and not new features.

@rodrigok
Copy link
Member Author

@graywolf336 changed, thanks.

@rodrigok rodrigok added this to the 0.64.0 milestone Apr 9, 2018
@rodrigok rodrigok merged commit 4e57a59 into develop Apr 9, 2018
@rodrigok rodrigok deleted the release-process branch April 9, 2018 12:04
@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants