Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] REST endpoint to recover forgotten password #10371

Merged
merged 5 commits into from
Apr 17, 2018

Conversation

MarcosSpessatto
Copy link
Member

Add REST /forgotPassword endpoint and tests.
Closes #10315.

@MarcosSpessatto MarcosSpessatto added this to the 0.64.0 milestone Apr 7, 2018
@MarcosSpessatto MarcosSpessatto self-assigned this Apr 7, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10371 April 7, 2018 00:21 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10371 April 7, 2018 00:51 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10371 April 7, 2018 00:53 Inactive
@@ -325,6 +325,22 @@ class API extends Restivus {
}
return response;
};
const forgotPassword = function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm not sure if this should live in here or in the users file. Thoughts @sampaiodiego

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, the endpoint could be something like /users.forgotPassword

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts as well. 👍

@sampaiodiego sampaiodiego changed the title [NEW] Add REST /forgotPassword endpoint [NEW] REST endpoint to recover forgotten password Apr 17, 2018
@sampaiodiego sampaiodiego merged commit 16b6190 into develop Apr 17, 2018
@sampaiodiego sampaiodiego deleted the feature/rest-forgot-password branch April 17, 2018 19:14
MarcosSpessatto added a commit that referenced this pull request Apr 19, 2018
…-api-chat-postmessage-validations

* commit 'a9fb4da5c847a456990a5d60369f0f52ff4a8bd8': (137 commits)
  Remove "secret" from REST endpoint /settings.oauth response
  [FIX] Directory sort and column sizes were wrong (#10403)
  [FIX] Add oauth services missing fields, and indicate whether the oauth service is customized (#10299)
  Show error message when email verification fails (#10446)
  Correct the column positions in the directory search for users (#10454)
  Fixed custom fields misalignment in registration form (#10463)
  [FIX] Unique identifier file not really being unique (#10341)
  [OTHER] More Listeners for Apps & Utilize Promises inside Apps (#10335)
  [FIX] Empty panel after changing a user's username (#10404)
  [FIX] Russian translation of "False" (#10418)
  [FIX] Links being embedded inside of blockquotes (#10496)
  [FIX] The 'channel.messages' REST API Endpoint error (#10485)
  [OTHER] Develop sync (#10487)
  [FIX] Button on user info contextual bar scrolling with the content (#10358)
  [FIX] "Idle Time Limit" using milliseconds instead of seconds (#9824)
  [NEW] Body of the payload on an incoming webhook is included on the request object (#10259)
  [FIX] Missing i18n translation key for "Unread" (#10387)
  [FIX] Owner unable to delete channel or group from APIs (#9729)
  [NEW] REST endpoint to recover forgotten password (#10371)
  Add REST endpoint chat.reportMessage, to report a message (#10354)
  ...
@philipbrito
Copy link
Contributor

philipbrito commented Apr 23, 2018

@MarcosSpessatto @sampaiodiego Is there a doc for this endpoint? Where in case of yes?

I need to know, for example, how the JSON looks like in case of the "user not found" error.

@sampaiodiego
Copy link
Member

@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants