[FIX] Message view mode setting was missing at user's preferences #10395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame changed from viewMode to messageViewMode to avoid any confusion with sidebarViewMode (+ migration to change name in database as well)
…one still works with it.
…ew_mode as both still will be translated with View_mode - Created an own section for Notifications in Account Preferences. Brings View Mode a bith more in context to it's section header - Optimized migration
kaiiiiiiiii
changed the title
karlprieb
previously approved these changes
Apr 10, 2018
…ll translation files I missed yesterday.
|
Idk, I don't think we should use auto translators. @RocketChat/core What you guys think? |
I agree. Let's let our community translators handle them, since we never know what the results actually are.. |
|
So @kaiiiiiiiii can you remove the auto translations? |
|
I'll do that, no worries :) |
karlprieb
approved these changes
Apr 10, 2018
rodrigok
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10326 (@himBeere)
This PR brings back the view mode for messages, which has accidentally been removed by @karlprieb in PR #10016.
I’ve done the following in addition:
I’m not quite sure if the migration’s gonna work like that. In my tests it does not remove the fields when migrating from an older version than 0.63.0.
Screenshot of Notifications section:
Screenshot of Messages section:
Regards,
Kai