[FIX] Wrong positioning of popover when using RTL languages #10428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdelavald
suggested changes
Apr 11, 2018
| top: `${ e.currentTarget.getBoundingClientRect().bottom + 10 }px`, | ||
| left: `${ e.currentTarget.getBoundingClientRect().left - 10 }px` | ||
| top: `${ e.currentTarget.getBoundingClientRect().bottom + 10 }px` | ||
| // left: `${ e.currentTarget.getBoundingClientRect().left - 10 }px` |
| @@ -75,7 +78,7 @@ Template.popover.onRendered(function() { | |||
| } | |||
|
|
|||
| popoverContent.style.top = `${ top }px`; | |||
| popoverContent.style.left = `${ left }px`; | |||
| popoverContent.style.left = `${ isRtl() ? left : left }px`; | |||
There was a problem hiding this comment.
Left and Left? No need for conditional then.
karlprieb
reviewed
Apr 11, 2018
|
please remove the comments. |
karlprieb
previously approved these changes
Apr 11, 2018
gdelavald
previously approved these changes
Apr 11, 2018
|
still some issues in design |
|
@fifou17 actually this is another problem, but I will fix it here.. |
|
The |
gdelavald
approved these changes
Apr 16, 2018
rodrigok
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now you can just pass the anchor element as
currentTargetand the script will find the right positionCloses #10068
before:
after:
