Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some missing translations #10435

Merged
merged 2 commits into from
Apr 16, 2018
Merged

Add some missing translations #10435

merged 2 commits into from
Apr 16, 2018

Conversation

gdelavald
Copy link
Contributor

Closes #10125

Add some translation calls where it was missing and add the Computer key to i18n list

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10435 April 12, 2018 13:34 Inactive
karlprieb
karlprieb previously approved these changes Apr 12, 2018
View reviewed changes
@karlprieb karlprieb added this to the 0.64.0 milestone Apr 12, 2018
@kaiiiiiiiii kaiiiiiiiii mentioned this pull request Apr 12, 2018
Closed
@kaiiiiiiiii
Copy link
Contributor

kaiiiiiiiii commented Apr 12, 2018 •
edited
Loading

Can you add a swedish translation for the word computer to your PR, so that #10185 can be closed as well?

I closed my PR (#10189) which did that in favor of yours :)

@gdelavald
Copy link
Contributor Author

@kaiiiiiiiii 👍

@rodrigok rodrigok changed the title [FIX] Add some missing translations Add some missing translations Apr 16, 2018
@rodrigok rodrigok merged commit bdd28e9 into develop Apr 16, 2018
@rodrigok rodrigok deleted the fix-some-missing-translations branch April 16, 2018 14:39
@kaiiiiiiiii kaiiiiiiiii mentioned this pull request Apr 22, 2018
Closed
@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlprieb karlprieb karlprieb approved these changes

@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees
No one assigned
Labels
ui/ux
Projects
None yet
Milestone
0.64.0
Development

Successfully merging this pull request may close these issues.

Some translations not working
5 participants
@gdelavald @kaiiiiiiiii @karlprieb @rodrigok @engelgabriel