Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Stop Firefox announcement overflowing viewport #10503

Merged
merged 3 commits into from
Apr 25, 2018
Merged

[FIX] Stop Firefox announcement overflowing viewport #10503

merged 3 commits into from
Apr 25, 2018

Commits on Apr 18, 2018

  1. Stop Firefox announcement overflowing viewport

    Fixes an issue where long announcement messages caused the right-hand
    sidebar to and associated icons to be pushed outside the viewport due
    to how non-wrapping whitespace was interacting with flex layout.
    
    As a tradeoff, this commit causes overflowing text to no longer be
    displayed with a nice ellipsis in other browsers, simply cutting it
    short instead.
    brendangadd authored Apr 18, 2018
    Configuration menu
    Copy the full SHA
    e0eb210 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2018

  1. Configuration menu
    Copy the full SHA
    51ce328 View commit details
    Browse the repository at this point in the history
  2. Restore announcement ellipsis overflow

    Announcment text is now wrapped in a `<p>` element which allows an
    extra flex container to control text overflow for long announcements.
    With this addition, announcements no longer make the right sidebar and
    its associated icons innaccessible by pushing them out of the viewport.
    
    A previous commit accomplished this by allowing whitespace to wrap,
    which caused overflowing text to clip rather than receive an ellipsis.
    This commit restores the ellipsis.
    brendangadd committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    930b879 View commit details
    Browse the repository at this point in the history