Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Option to ignore users on channels #10517

Merged
merged 28 commits into from
Apr 20, 2018
Merged

[NEW] Option to ignore users on channels #10517

merged 28 commits into from
Apr 20, 2018

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 19, 2018

Closes #9785

as @rodrigok said on #9785

Specification:

  • The list will be per room
  • Will be saved in user's subscription as an array of users to mute
  • Will be a field in room's setting using the component we already have to select users when creating a new channel
  • There will be a button in user's detail view and in message's context menu to mute/unmute the user (methods to be developed)
  • Will show an icon (to be defined) in members list to mark muted users
  • Will affect the rendering of the messages
  • Will hide the user's messages when listed in muted array but will keep the username adding a button to expand/show the messages
  • Should not send notifications and emails of messages from muted users
  • ~Should update the array of muted usernames when user change his username (RocketChat._setUsername)
  • The minimized message will be designed soon ??

lduo4kiuni
image

@gdelavald thanks <3

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10517 April 19, 2018 21:44 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-10517 April 19, 2018 22:30 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-10517 April 19, 2018 22:30 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-10517 April 19, 2018 22:31 Inactive
Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in this comment, #9785 (comment), the rest api wrapper is needed as well.

@ggazzo ggazzo had a problem deploying to rocket-chat-pr-10517 April 19, 2018 23:06 Failure
@ggazzo
Copy link
Member Author

ggazzo commented Apr 20, 2018

I'm waiting for the API too (:

@ggazzo ggazzo temporarily deployed to rocket-chat-pr-10517 April 20, 2018 01:17 Inactive
@ggazzo
Copy link
Member Author

ggazzo commented Apr 20, 2018

just a joke <3

@karlprieb
Copy link
Contributor

@graywolf336 yep... we will change this design probably on the RC. Our design team is working on that.

@ggazzo ggazzo temporarily deployed to rocket-chat-pr-10517 April 20, 2018 04:06 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10517 April 20, 2018 07:11 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10517 April 20, 2018 07:12 Inactive
karlprieb
karlprieb previously approved these changes Apr 20, 2018
@karlprieb karlprieb added this to the 0.64.0 milestone Apr 20, 2018
@karlprieb karlprieb dismissed their stale review April 20, 2018 17:12

waiting for @ggazzo type checker update

@ggazzo ggazzo temporarily deployed to rocket-chat-pr-10517 April 20, 2018 21:22 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-10517 April 20, 2018 21:49 Inactive
@rodrigok rodrigok changed the title [NEW] Ignore user on channels [NEW] Option to ignore users on channels Apr 20, 2018
@rodrigok rodrigok merged commit 93b1641 into develop Apr 20, 2018
@rodrigok rodrigok deleted the ignore0user branch April 20, 2018 22:34
@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mute Feature: Hide messages from specific users
6 participants