Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Improvements to notifications logic #10686

Merged
merged 20 commits into from
May 9, 2018
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix auto away default value test
  • Loading branch information
sampaiodiego committed May 5, 2018
commit 743839bbe6ea7c4024a108507e9d529491502382
4 changes: 2 additions & 2 deletions tests/end-to-end/ui/11-admin.js
Original file line number Diff line number Diff line change
@@ -731,8 +731,8 @@ describe('[Administration]', () => {
admin.accountsEnableAutoAwayFalse.isVisible().should.be.true;
});
it('the enable auto away field value should be true', () => {
Copy link
Member Author

@sampaiodiego sampaiodiego May 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense now.. the test description is correct, but the test code was wrong. 🤦‍♂️

admin.accountsEnableAutoAwayTrue.isSelected().should.be.false;
admin.accountsEnableAutoAwayFalse.isSelected().should.be.true;
admin.accountsEnableAutoAwayTrue.isSelected().should.be.true;
admin.accountsEnableAutoAwayFalse.isSelected().should.be.false;
});

it('it should show the idle timeout limit field', () => {