-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Improvements to notifications logic #10686
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7d53503
Notification logic improvements
sampaiodiego 06d74e2
Use rawCollection for slow operations
sampaiodiego bde1ee2
Denormalize user notification preferences
sampaiodiego dae18bf
Split notification functions into multiple files
sampaiodiego 1884e99
Code cleanup
sampaiodiego b7124f1
Remove rawCollection
sampaiodiego f538d83
Move specific code to their respective files
sampaiodiego bdc6130
Respect server's default preferences
sampaiodiego de6d492
Add default email preference to user's preferences
sampaiodiego 2bddb06
Change default value of auto away to true
sampaiodiego 6ab4f88
Save notifications accordingly
sampaiodiego b529103
Use correct room name for email notifications
sampaiodiego a9edf7a
Merge branch 'develop' into improvements-to-notifcations-logic
sampaiodiego ad07123
Preserve email notification fixes
sampaiodiego 743839b
Fix auto away default value test
sampaiodiego 46f73bc
Remove duplicated index and add some comments
sampaiodiego c4815d2
Honor Notifications_Max_Room_Members for all notifications
sampaiodiego 1c8200b
Remove unread index
sampaiodiego d71d48a
Minor code improvements
sampaiodiego d6a9905
Merge branch 'develop' into improvements-to-notifcations-logic
rodrigok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix auto away default value test
- Loading branch information
commit 743839bbe6ea7c4024a108507e9d529491502382
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it makes sense now.. the test description is correct, but the test code was wrong. 🤦♂️