-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Livechat visitor not being prompted for transcript when himself is closing the chat #10767
[FIX] Livechat visitor not being prompted for transcript when himself is closing the chat #10767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the sweetalert
update broke the department switch. the swal
confirmation is not shown, it stays behind the switch department modal.
also, if changing the sweetalert package, why not use the npm version instead of a meteor package?
@sampaiodiego, thanks for you feedback! |
…witch form. Removed meteor swal package, start using npm version (2.x).
Fix |
@@ -804,6 +804,10 @@ input:focus { | |||
border-top-left-radius: inherit; | |||
} | |||
|
|||
.swal2-container { | |||
z-index: 10000 !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of changing the third party CSS I would rather change our own..
the largest z-index
we have is 200
. so it would be better changing modal's z-index instead of sweetalert's
if ((typeof response === 'boolean') && !response) { | ||
confirmButtonText: t('yes') | ||
}).then((result) => { | ||
if ((typeof result.value === 'boolean') && !response) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since there are a lot of changes here, what do you think on improving it's logic to look more "flat" (as the previous code improvements) ?
# Conflicts: # packages/rocketchat-livechat/.app/package.json
…om:RocketChat/Rocket.Chat into livechat-send-transcription-on-client-side # Conflicts: # packages/rocketchat-livechat/.app/package.json
Hi @sampaiodiego! |
Closes #7681
This PR fixes the issue that was happening when a visitor closes the chat. If the setting for sending the transcript by email is enabled, it should prompt the visitor to send a copy of the chat, but this was not occurring on client side, only if the chat was closed by agent.
This was occurring due to a bug on
sweet alert 1.x
, which was not working well when usingswal
in sequence. After changing the package to a newer package, usingsweet alert 2.x
, the bug is no longer happening.