Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Replace variable 'mergeChannels' with 'groupByType'. #10954

Merged
merged 9 commits into from
Jun 6, 2018
Merged

[NEW] Replace variable 'mergeChannels' with 'groupByType'. #10954

merged 9 commits into from
Jun 6, 2018

Conversation

mikaelmello
Copy link
Contributor

Finishing #10055

@engelgabriel
Copy link
Member

Thanks for the cleanup @mikaelmello !!!

@engelgabriel engelgabriel requested review from karlprieb and ggazzo June 4, 2018 02:39
@engelgabriel engelgabriel added this to the 0.66.0 milestone Jun 4, 2018
ggazzo
ggazzo previously approved these changes Jun 4, 2018
View reviewed changes
@engelgabriel engelgabriel changed the title [NEW] Changes all 'mergeChannels' to 'groupByType'. [NEW] Replace variable 'mergeChannels' with 'groupByType'. Jun 6, 2018
@engelgabriel engelgabriel merged commit 9a5ecb6 into RocketChat:develop Jun 6, 2018
@mikaelmello mikaelmello deleted the groupByType branch June 7, 2018 01:07
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelgabriel engelgabriel engelgabriel approved these changes

@ggazzo ggazzo ggazzo left review comments

@karlprieb karlprieb Awaiting requested review from karlprieb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.66.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mikaelmello @engelgabriel @ggazzo @rodrigok