Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Don't ask me again checkbox on hide room modal #10973

Merged
merged 6 commits into from
Jun 12, 2018

Conversation

karlprieb
Copy link
Contributor

Closes #10905

This PR implements a solution to have a "Don't ask me again" checkbox on modals.
You can remove the actions that has don't ask me again activated on the user preferences menu.

2018-06-01 16 15 46

@karlprieb karlprieb added the ui/ux label Jun 1, 2018
@karlprieb karlprieb added this to the 0.66.0 milestone Jun 1, 2018
@karlprieb karlprieb requested a review from ggazzo June 1, 2018 19:20
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10973 June 1, 2018 19:20 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10973 June 1, 2018 20:06 Inactive
@RocketChat RocketChat deleted a comment Jun 1, 2018
@RocketChat RocketChat deleted a comment Jun 1, 2018
@RocketChat RocketChat deleted a comment Jun 1, 2018
@RocketChat RocketChat deleted a comment Jun 1, 2018
@RocketChat RocketChat deleted a comment Jun 1, 2018
@@ -100,6 +100,9 @@ Template.accountPreferences.helpers({
},
notificationsSoundVolume() {
return RocketChat.getUserPreference(Meteor.user(), 'notificationsSoundVolume');
},
dontAskAGainList() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name looks like a typo..?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right!

ggazzo
ggazzo previously approved these changes Jun 11, 2018
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-10973 June 12, 2018 03:10 Abandoned
@engelgabriel engelgabriel merged commit 099bee3 into develop Jun 12, 2018
@engelgabriel engelgabriel deleted the dont-ask-me-again branch June 12, 2018 03:12
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature "don't ask it again" for some actions
4 participants