Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming username.username to username.value for clarity #10986

Merged
merged 4 commits into from
Jun 4, 2018
Merged

Renaming username.username to username.value for clarity #10986

merged 4 commits into from
Jun 4, 2018

Conversation

engelgabriel
Copy link
Member

Just for clarity

@engelgabriel engelgabriel added this to the 0.66.0 milestone Jun 4, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10986 June 4, 2018 03:08 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10986 June 4, 2018 03:51 Inactive
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-10986 June 4, 2018 05:43 Abandoned
@engelgabriel engelgabriel merged commit b037a63 into develop Jun 4, 2018
@engelgabriel engelgabriel deleted the username-username branch June 4, 2018 05:45
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.66.0
Development

Successfully merging this pull request may close these issues.
1 participant
@engelgabriel