Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Livechat icon with status #11177

Merged
merged 6 commits into from
Jun 19, 2018
Merged

[FIX] Livechat icon with status #11177

merged 6 commits into from
Jun 19, 2018

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jun 18, 2018 •
edited
Loading

Closes #9771

Before

captura de tela de 2018-07-10 01-08-01

After

captura de tela de 2018-07-10 01-30-51

@tassoevan tassoevan changed the title [FIX livechat status icons [FIX] Livechat icon with status Jun 18, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11177 June 18, 2018 17:21 Inactive
@tassoevan tassoevan requested a review from ggazzo June 18, 2018 17:22
@tassoevan tassoevan added this to the 0.66.0 milestone Jun 18, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11177 June 18, 2018 20:51 Inactive
ggazzo
ggazzo requested changes Jun 19, 2018
View reviewed changes
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep Session.get(user_${ this.username }_status) inside one separated template, to avoid render the row

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11177 June 19, 2018 19:10 Inactive
@ggazzo ggazzo merged commit 2ee066e into develop Jun 19, 2018
@ggazzo ggazzo deleted the fix-livechat-status-icons branch June 19, 2018 20:59
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
ui/ux
Projects
None yet
Milestone
0.66.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tassoevan @ggazzo @engelgabriel