Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Allow multiple subcommands in MIGRATION_VERSION env variable #11184

Merged
merged 2 commits into from
Sep 21, 2018
Merged

[NEW] Allow multiple subcommands in MIGRATION_VERSION env variable #11184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e3e52c
Allow multiple subcommands in MIGRATION_VERSION env variable
arch119 Jun 18, 2018
11f6349
Merge branch 'develop' into develop
arch119 Jun 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions packages/rocketchat-migrations/migrations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,16 @@ import moment from 'moment';

The ordering of migrations is determined by the version you set.

To run the migrations, set the MIGRATE environment variable to either
To run the migrations, set the MIGRATION_VERSION environment variable to either
'latest' or the version number you want to migrate to. Optionally, append
',exit' if you want the migrations to exit the meteor process, e.g if you're
migrating from a script (remember to pass the --once parameter).

e.g:
MIGRATE="latest" mrt # ensure we'll be at the latest version and run the app
MIGRATE="latest,exit" mrt --once # ensure we'll be at the latest version and exit
MIGRATE="2,exit" mrt --once # migrate to version 2 and exit
MIGRATION_VERSION="latest" mrt # ensure we'll be at the latest version and run the app
MIGRATION_VERSION="latest,exit" mrt --once # ensure we'll be at the latest version and exit
MIGRATION_VERSION="2,exit" mrt --once # migrate to version 2 and exit
MIGRATION_VERSION="2,rerun,exit" mrt --once # rerun migration script for version 2 and exit

Note: Migrations will lock ensuring only 1 app can be migrating at once. If
a migration crashes, the control record in the migrations collection will
Expand Down Expand Up @@ -162,12 +163,12 @@ Migrations.migrateTo = function(command) {
if (_.isUndefined(command) || command === '' || this._list.length === 0) { throw new Error(`Cannot migrate using invalid command: ${ command }`); }

let version;
let subcommand;
let subcommands;
if (typeof command === 'number') {
version = command;
} else {
version = command.split(',')[0];
subcommand = command.split(',')[1];
subcommands = command.split(',').slice(1);
}

const maxAttempts = Migrations.options.maxAttempts;
Expand All @@ -177,7 +178,7 @@ Migrations.migrateTo = function(command) {
if (version === 'latest') {
migrated = this._migrateTo(_.last(this._list).version);
} else {
migrated = this._migrateTo(parseInt(version), (subcommand === 'rerun'));
migrated = this._migrateTo(parseInt(version), (subcommands.includes('rerun')));
}
if (migrated) {
break;
Expand Down Expand Up @@ -214,7 +215,7 @@ Migrations.migrateTo = function(command) {
}

// remember to run meteor with --once otherwise it will restart
if (subcommand === 'exit') { process.exit(0); }
if (subcommands.includes('exit')) { process.exit(0); }
};

// just returns the current version
Expand Down