Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Directory css #11206

Merged
merged 8 commits into from
Jun 21, 2018
Merged

Regression: Directory css #11206

merged 8 commits into from
Jun 21, 2018

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 21, 2018

before:

image

after

image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11206 June 21, 2018 00:27 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-11206 June 21, 2018 00:55 Inactive
@ggazzo ggazzo added this to the 0.66.0 milestone Jun 21, 2018
@ggazzo ggazzo added the ui/ux label Jun 21, 2018
rodrigok
rodrigok previously approved these changes Jun 21, 2018
@@ -105,7 +109,7 @@
color: var(--rc-color-primary-light);

font-size: 0.75rem;
font-weight: 400;
font-weight: 500;
line-height: 1rem;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add display: inline-block and vertical-align: middle for all children elements of table-fake-th to align them vertically

@ggazzo ggazzo dismissed karlprieb’s stale review June 21, 2018 01:19

he doesn't know nothing about css :)

@rodrigok rodrigok merged commit ee86332 into develop Jun 21, 2018
@rodrigok rodrigok deleted the fix-table-css branch June 21, 2018 01:54
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants