Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Stop sort callbacks on run #11330

Merged
merged 2 commits into from
Jul 5, 2018
Merged

[IMPROVE] Stop sort callbacks on run #11330

merged 2 commits into from
Jul 5, 2018

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 4, 2018

We dont need sort the callbacks each time we call them, we just need sort on add... I'm not sure if will save a lot of time, but its the right logic... As we dont need return a new Promise each cycle

@ggazzo ggazzo requested review from sampaiodiego and rodrigok July 4, 2018 04:15
rodrigok
rodrigok approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@rodrigok rodrigok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and logic were reviewed and approved, not tested

@ggazzo ggazzo merged commit d08d48c into develop Jul 5, 2018
@ggazzo ggazzo deleted the dont-sort-callback-each-run branch July 5, 2018 17:35
@sampaiodiego sampaiodiego mentioned this pull request Jul 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggazzo @rodrigok @engelgabriel