[FIX] Fixed text for "bulk-register-user" #11558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same text was used for bulk-register-c (channels) and bulk-register-user. Adjusted the text for bulk-register-user and its associated description line in the English translation JSON file.
|
|
|
Is there something else I need to do for this? The one check is still pending and this is my first time contributing to this project and I want to make sure I didnt miss anything. The fix is a simple change to a mistyped string so it shouldnt effect any building and should be an easy review. let me know how i can help. Thanks. |
vynmera
previously approved these changes
Jul 25, 2018
|
I am a little confused. It seems as though the change I corrected with this pull request was fixed else where? Is that accurate? does that happen often? I was hoping to have "contributed" but i guess someone found it also and included it with another pull request (im guessing one that fixed more than just some text). Just wondering. Thanks |
tassoevan
approved these changes
Feb 5, 2019
Montel
pushed a commit
to Montel/Rocket.Chat
that referenced
this pull request
Feb 13, 2019
The same text was used for bulk-register-c (channels) and bulk-register-user. Adjusted the text for bulk-register-user and its associated description line in the English translation JSON file.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same text was used for bulk-register-c (channels) and bulk-register-user. Adjusted the text for bulk-register-user and its associated description line in the English translation JSON file.