Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Livechat agent joining on pick from guest pool #12097

Conversation

mrsimpson
Copy link
Collaborator

What this fixes

As a guest's conversation is picked from the livechat queue, the agent is getting assigned to the room.
However, this was not properly subscribed to on the widget.
This lead to multiple issues:

  • The agent's name was not depicted on the header of the livechat window
  • The full name of the agent was not displayed but his username

livechat fixed bugs

What's been done

The streamer subscription had a filter which did not match the actual property of the room.

It's a one-liner, but has quite nasty side-effects - and was tedious to fix. Any efforts on providing integration tests for livechat on the horizon?

@sampaiodiego
Copy link
Member

Any efforts on providing integration tests for livechat on the horizon?

The new client will have tests from the start. We need to start adding tests on Rocket.Chat side as well.

@sampaiodiego sampaiodiego changed the title [Livechat] Fix agent joining on pick from guest pool [FIX] Livechat agent joining on pick from guest pool Sep 20, 2018
@sampaiodiego sampaiodiego merged commit 933378a into RocketChat:develop Sep 20, 2018
@mrsimpson
Copy link
Collaborator Author

Any efforts on providing integration tests for livechat on the horizon?

The new client will have tests from the start. We need to start adding tests on Rocket.Chat side as well.

Awesome! When is it going to hit the road?

@mrsimpson mrsimpson deleted the core/fix/livechat-guest-pool-agent-name branch September 21, 2018 06:24
@sampaiodiego
Copy link
Member

I was hoping to have the new client by this release 😞 hopefully we can have it by the next one 🤞

This was referenced Sep 28, 2018
@tntho
Copy link

tntho commented Nov 26, 2018

Hi @mrsimpson, I think your fix conflict with #11011. In this pull request he changed token to vistorToken, but in your pull request you changed vistorToken to token.

@mrsimpson
Copy link
Collaborator Author

@IITNTII thanks for notifying! Obviously, this was overlapping. @renatobecker and I just learned this the hard way before I recalled your message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants