[FIX] Livechat agent joining on pick from guest pool #12097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this fixes
As a guest's conversation is picked from the livechat queue, the agent is getting assigned to the room.
However, this was not properly subscribed to on the widget.
This lead to multiple issues:
What's been done
The streamer subscription had a filter which did not match the actual property of the room.
It's a one-liner, but has quite nasty side-effects - and was tedious to fix. Any efforts on providing integration tests for livechat on the horizon?