Fix: e2e password visible on always-on alert message. #12139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -547,6 +547,7 @@ | |||
| "clear_history": "Clear History", | |||
| "Click_here": "Click here", | |||
| "Click_here_for_more_info": "Click here for more info", | |||
| "Click here to view and copy your password.": "Click here to view and copy your password.", | |||
There was a problem hiding this comment.
Shouldn't this be at least _ separated for consistency?
geekgonecrazy
approved these changes
Sep 25, 2018
rodrigok
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the password from the always-on alert message, so that the user will only see it when clicking on the alert.