Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Add decoding for commonName (cn) and displayName attributes for SAML #12347

Merged
merged 16 commits into from
Mar 12, 2019
Merged

Conversation

pkolmann
Copy link
Contributor

I want to create users via SAML. Currently the SAML IDP sends the Attributes urn:oid-encoded. This patch adds the decoding for commonName (cn) and displayName attributes.

Secondly it adds the displayName as a possibility for the name of the new user.

Add displayName as a possibility for the name of the new user
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ pkolmann
✅ sampaiodiego
✅ engelgabriel
❌ Rocket Chat


Rocket Chat seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pkolmann
Copy link
Contributor Author

I have signed the CLA already but it still shows as unsigned :(
and tried to finish the circleci build, but it's on hold and if I click on approve, nothing happens.

Can anyone suggest any solutions? Thanks

@pkolmann
Copy link
Contributor Author

pkolmann commented Nov 4, 2018

@MarcosSpessatto could you please review my changes and help me get them merged. Thanks

@pkolmann
Copy link
Contributor Author

@Hudell do you have any hint for me, if this change could be merged?

Hudell
Hudell previously approved these changes Dec 10, 2018
@Hudell Hudell added this to the 0.73.0 milestone Dec 10, 2018
@rodrigok
Copy link
Member

@pkolmann can you fix the conflicts?

@pkolmann
Copy link
Contributor Author

pkolmann commented Jan 9, 2019

@rodrigok I fear I f*ed up my branch again... :(

I have an updated patch that applies cleanly to 0.73.1. Can you use this as well?

Maybe someone can tell me, where I did the update of my branch wrong:

git clone git@github.com:pkolmann/Rocket.Chat.git rocketChatGit
cd rocketChatGit/
git remote add upstream git@github.com:RocketChat/Rocket.Chat.git
git merge upstream/master
git push

rocketChat-SAML.diff.txt

@Hudell
Copy link
Contributor

Hudell commented Jan 9, 2019

You should use the develop branch instead of master

@pkolmann
Copy link
Contributor Author

@Hudell thanks for the hint. I managed now to get everything uptodate. Now you should be able to pull.

@pkolmann
Copy link
Contributor Author

@rodrigok the branch is now in sync and can be merged. Thanks

@engelgabriel engelgabriel modified the milestones: 0.73.0, 1.0.0 Mar 11, 2019
@engelgabriel
Copy link
Member

@sampaiodiego can you review and merge this?

@sampaiodiego sampaiodiego changed the title [NEW] Add decoding for commonName (cn) and displayName attributes [IMPROVE] Add decoding for commonName (cn) and displayName attributes for SAML Mar 12, 2019
@sampaiodiego sampaiodiego merged commit c4bc234 into RocketChat:develop Mar 12, 2019
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants