[FIX] Remove Room info for Direct Messages (#9383) #12429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2429-vinade-room-info-challenge
…2429-vinade-room-info-challenge
ggazzo
force-pushed
the
room-info-challenge
branch
from
82b3b94 to
47528a7
Compare
…2429-vinade-room-info-challenge
…2429-vinade-room-info-challenge
ggazzo
approved these changes
Mar 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve this issue I had to do 3 things:
The main point of this issue was simple to solve, but it created another issue.
The E2E toggle button is inside Room Info, and if there is no Room Info then the user cannot reach the E2E button.
So, I'm proposing a second E2E toggle button beside Favorite toggle button at header. Like this:
E2E off :
E2E on :
The new toggle button replaces the old E2E icon (which was only showed if E2E was on).
Now the button is always shown. And the button color shows the E2E state (green for on and grey for off), like the Favorite toggle button.
The last item is another issue I found testing. Later I searched on Github and I found that someone discovered it before ( #12417 ).
I noticed that E2E cannot be enabled at Public rooms. It always shows an error message.
And it seems to be done on purpose (to not be possible to enable E2E for public rooms). So I removed this option for Public rooms from interface.
Public room wihout E2E button
I had to solve this last issue because with the new E2E button this issue would become more frequent.
Closes #9383