Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix issue cannot filter channels by name #12952

Merged
merged 7 commits into from
Mar 1, 2019

Conversation

huydang284
Copy link
Contributor

Hi team,

I fix the issue that cannot filter channels by name. I think it was a mistake.

Regards,
Huy Dang

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2018

CLA assistant check
All committers have signed the CLA.

@tassoevan tassoevan requested review from rodrigok and ggazzo December 15, 2018 14:07
@ggazzo ggazzo added this to the 0.75.0 milestone Feb 5, 2019
ggazzo
ggazzo previously approved these changes Feb 5, 2019
@ggazzo
Copy link
Member

ggazzo commented Feb 7, 2019

hey @huydang284, you pr looks good, but I could not find where we are using that method, ( I was thinking about remove it) I just found old templates using this method, could you say me here you are using this methods?

@huydang284
Copy link
Contributor Author

Hi @ggazzo, I used that method in my custom project.

@ggazzo
Copy link
Member

ggazzo commented Mar 1, 2019

@huydang284 please check if there is another method that you could use instead, because, probably we gonna remove that method...

@ggazzo ggazzo merged commit 8bddc37 into RocketChat:develop Mar 1, 2019
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants