[NEW] Make ldap avatar source field customizable #12958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbartsch
changed the title
|
@traxanos can you review this? |
|
@sampaiodiego Any ideas on how to make this request visible for some reviewers? |
|
We need that PR a lot, because from thumbnailPhoto we get a very low quality avatars in Rocket.Chat. |
|
|
# Conflicts: # packages/rocketchat-i18n/i18n/de-IN.i18n.json # packages/rocketchat-i18n/i18n/de.i18n.json # packages/rocketchat-ldap/server/settings.js # packages/rocketchat-ldap/server/sync.js
rodrigok
approved these changes
Jun 19, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NEW] Make ldap avatar source field customizable
Closes #8835
Just added a new input field called User Avatar Field to LDAP/SYNC configuration. While syncing ldap users, we should look for a user property with this name. If there is none, use
thumbnailPhotoandjpegPhotoas before.