Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] new icons #13289

Merged
merged 39 commits into from
Feb 5, 2019
Merged

[IMPROVE] new icons #13289

merged 39 commits into from
Feb 5, 2019

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jan 30, 2019

  • updated some icons
  • html generator to check icons
  • sprite generator

image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13289 January 30, 2019 13:07 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13289 January 30, 2019 13:10 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13289 January 30, 2019 13:56 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13289 January 30, 2019 14:42 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13289 January 30, 2019 17:20 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13289 January 30, 2019 17:23 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13289 January 30, 2019 21:40 Inactive
@engelgabriel engelgabriel added this to the 0.75.0 milestone Jan 31, 2019
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13289 January 31, 2019 20:12 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13289 February 1, 2019 19:39 Inactive
* develop:
  [NEW] Limit all DDP/Websocket requests (configurable via admin panel) (#13311)
  [FIX] Mobile view and re-enable E2E tests (#13322)
  [NEW] REST endpoint to forward livechat rooms (#13308)
  [FIX] Hipchat Enterprise Importer not generating subscriptions (#13293)
  [FIX] Message updating by Apps (#13294)
  [FIX]  REST endpoint for creating custom emojis (#13306)
  [FIX] Preview of image uploads were not working when apps framework is enable (#13303)
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13289 February 3, 2019 13:16 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-13289 February 4, 2019 13:16 Inactive
@@ -155,13 +155,6 @@
font-size: 1rem;
}

&__room-type {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove sidebar-item__room-type from templates too.

// play animation
$(e.currentTarget).find('.rc-icon').addClass('play');
$(e.currentTarget).parent().addClass('loading');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we avoid jQuery here?

@ggazzo ggazzo merged commit 18932c1 into develop Feb 5, 2019
@ggazzo ggazzo deleted the new-icons branch February 5, 2019 03:07
Montel pushed a commit to Montel/Rocket.Chat that referenced this pull request Feb 13, 2019
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants