[FIX] Notify private settings changes even on public settings changed #13369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Guilherme Gazzo <guilherme.gazzo@rocket.chat>
ggazzo
approved these changes
Feb 5, 2019
|
I don't know how you found this bug, well done :) |
|
Thanks! |
Montel
pushed a commit
to Montel/Rocket.Chat
that referenced
this pull request
Feb 13, 2019
…RocketChat#13369) Closes RocketChat#11604 Closes RocketChat#12399 An `else` directive introduced the issue at version 0.67.0: https://github.com/RocketChat/Rocket.Chat/pull/10749/files#diff-ff8f9f02a53856a978c533000a92bd12R70
sampaiodiego
pushed a commit
that referenced
this pull request
Feb 14, 2019
…#13369) Closes #11604 Closes #12399 An `else` directive introduced the issue at version 0.67.0: https://github.com/RocketChat/Rocket.Chat/pull/10749/files#diff-ff8f9f02a53856a978c533000a92bd12R70
Merged
bhardwajaditya
pushed a commit
to bhardwajaditya/Rocket.Chat
that referenced
this pull request
Mar 17, 2019
…RocketChat#13369) Closes RocketChat#11604 Closes RocketChat#12399 An `else` directive introduced the issue at version 0.67.0: https://github.com/RocketChat/Rocket.Chat/pull/10749/files#diff-ff8f9f02a53856a978c533000a92bd12R70
wreiske
added a commit
to wreiske/Rocket.Chat
that referenced
this pull request
Apr 28, 2019
…nto ldap-admin-groups * 'develop' of https://github.com/RocketChat/Rocket.Chat: (21 commits) Regression: Active room was not being marked (RocketChat#14276) Rename Cloud to Connectivity Services & split Apps in Apps and Marketplace (RocketChat#14211) LingoHub based on develop (RocketChat#14178) [IMPROVE] Replace livechat inquiry dialog with preview room (RocketChat#13986) Bump version to 0.74.3 Room loading improvements (RocketChat#13471) [FIX] Invalid condition on getting next livechat agent over REST API endpoint (RocketChat#13360) [IMPROVE] Open rooms quicker (RocketChat#13417) [FIX] "Test Desktop Notifications" not triggering a notification (RocketChat#13457) [FIX] Translated and incorrect i18n variables (RocketChat#13463) Regression: Remove console.log on email translations (RocketChat#13456) [FIX] Properly escape custom emoji names for pattern matching (RocketChat#13408) [FIX] Not translated emails (RocketChat#13452) Added missing package dependency (RocketChat#13437) Update Russian localization (RocketChat#13244) [IMPROVE] Allow configure Prometheus port per process via Env Var (RocketChat#13436) [IMPROVE] Add API option "permissionsRequired" (RocketChat#13430) [FIX] Several Problems on HipChat Importer (RocketChat#13336) Add the missing uniqueId to the push notifications (RocketChat#13423) [FIX] Notify private settings changes even on public settings changed (RocketChat#13369) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11604
Closes #12399
Closes #12144
An
elsedirective introduced the issue at version 0.67.0: https://github.com/RocketChat/Rocket.Chat/pull/10749/files#diff-ff8f9f02a53856a978c533000a92bd12R70