[NEW] add failed login audit log writing #13387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping? |
|
What's the issue here? |
|
even if the discussion - see linked issue - come to the conclusion that having this feature configurable (and disabled by default) no one took care about this PR. Right now we need to fix the code as far as I see it, as the base has changed |
|
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2885
This PR adds the capability of logging failed login attempts. This can be used later for analysis / monitoring / fail2ban tooling.
The feature provides the option to
The log lines written are of this kind (in this example Forwarded For IP is enabled, everything else disabled)