Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Deprecate fixCordova helper #13598

Merged
merged 2 commits into from
Mar 2, 2019
Merged

[IMPROVE] Deprecate fixCordova helper #13598

merged 2 commits into from
Mar 2, 2019

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Mar 1, 2019 •
edited by rodrigok
Loading

🌆
closes #11924

@tassoevan tassoevan added this to the 1.0.0 milestone Mar 1, 2019
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13598 March 1, 2019 21:04 Inactive
@ura14h
Copy link
Contributor

ura14h commented Mar 2, 2019

If fixCordova helper is deleted, please also check #11924 .

@rodrigok
Copy link
Member

rodrigok commented Mar 2, 2019

@ura14h this PR will solve the issue you mentioned. Thanks

@rodrigok rodrigok mentioned this pull request Mar 2, 2019
Merged
@rodrigok rodrigok merged commit 2e9b0ff into develop Mar 2, 2019
@rodrigok rodrigok deleted the improve/remove-legacy-cordova-helper branch March 2, 2019 20:56
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

@ggazzo ggazzo Awaiting requested review from ggazzo

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees
No one assigned
Labels
type: improvement ui/ux
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

channel avatar is not shown when Rocket.Chat is running in subdir
4 participants
@tassoevan @ura14h @rodrigok @engelgabriel