Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing (almost) every dynamic imports #13767

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Removing (almost) every dynamic imports #13767

merged 1 commit into from
Mar 18, 2019

Conversation

MarcosSpessatto
Copy link
Member

Removing almost all dynamic imports, except those with circular dependency between archives.

 app/models/server/Messages.js => app/file-upload/server/lib/FileUpload.js

 app/ui-cached-collection/client/models/CachedCollection.js => app/ui-utils/client/lib/RoomManager.js

 app/ui-cached-collection/client/models/CachedCollection.js => app/models/client/ChatRoom.js

 app/ui-cached-collection/client/models/CachedCollection.js => app/models/client/CachedChatRoom.js

 app/ui-utils/client/lib/MessageAction.js => app/ui/client/views/app/room.js

@MarcosSpessatto MarcosSpessatto added this to the 1.1.0 milestone Mar 18, 2019
@rodrigok rodrigok modified the milestones: 1.1.0, 1.0.0 Mar 18, 2019
@rodrigok rodrigok merged commit 5851725 into develop Mar 18, 2019
@rodrigok rodrigok deleted the remove-dynamic-imports branch March 18, 2019 14:49
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
type: improvement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcosSpessatto @rodrigok @engelgabriel