Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate /api/v1/info in favor of /api/info #13798

Merged
merged 3 commits into from
Apr 6, 2019
Merged

Deprecate /api/v1/info in favor of /api/info #13798

merged 3 commits into from
Apr 6, 2019

Conversation

MarcosSpessatto
Copy link
Member

No description provided.

@MarcosSpessatto MarcosSpessatto added this to the 1.0.0 milestone Mar 19, 2019
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13798 March 19, 2019 20:15 Inactive
@MarcosSpessatto MarcosSpessatto mentioned this pull request Mar 19, 2019
Merged
ggazzo
ggazzo requested changes Mar 21, 2019
View reviewed changes
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about
versionWillRemove
versionWillBeRemoved

@d-gubert
Copy link
Member

what do you think about
versionWillRemove
versionWillBeRemoved

What about
removedOnVersion
versionRemove
?

@MarcosSpessatto
Copy link
Member Author

what do you think about
versionWillRemove
versionWillBeRemoved

My bad, I forgot the d when I did the function. 🙄

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13798 March 22, 2019 13:20 Inactive
@engelgabriel engelgabriel requested a review from ggazzo April 6, 2019 01:42
@rodrigok rodrigok merged commit 472a6ea into develop Apr 6, 2019
@rodrigok rodrigok deleted the deprecate-v1-info branch April 6, 2019 14:26
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees
No one assigned
Labels
feat: api feat: rest
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MarcosSpessatto @d-gubert @rodrigok @ggazzo @engelgabriel