Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Display first message when taking Livechat inquiry #13896

Merged
merged 11 commits into from
Apr 2, 2019
Merged

[FIX] Display first message when taking Livechat inquiry #13896

merged 11 commits into from
Apr 2, 2019

Conversation

renatobecker-zz
Copy link

Closes #13668.

Since the new Livechat client gets a new room before sending messages, this change has impacted on the Guest Pool routing method because now the first message is no longer stored into the Inquiry collection.
Due to that, now the Take Inquiry dialog will retrieve the first message by calling a server-side method.

@renatobecker-zz renatobecker-zz added this to the 1.0.0 milestone Mar 25, 2019
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13896 March 25, 2019 17:40 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13896 March 25, 2019 18:40 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13896 March 26, 2019 00:54 Inactive
tassoevan
tassoevan previously approved these changes Mar 26, 2019
View reviewed changes
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13896 March 26, 2019 13:11 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13896 March 26, 2019 13:35 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-13896 March 26, 2019 17:51 Inactive
@sampaiodiego sampaiodiego temporarily deployed to rocket-chat-pr-13896 March 26, 2019 17:57 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13896 March 27, 2019 16:52 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13896 March 28, 2019 12:46 Inactive
sampaiodiego
sampaiodiego requested changes Mar 29, 2019
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be fixed the other way around? like, fix by adding the message on the inquiry again?

what happened to that code? is it obsolete now? should it be removed then?

@renatobecker-zz
Copy link
Author

renatobecker-zz commented Mar 29, 2019 •
edited
Loading

should it be fixed the other way around? like, fix by adding the message on the inquiry again?

what happened to that code? is it obsolete now? should it be removed then?

The new livechat gets the room before sending the first message, so when the inquiry is created, no message object is passed to the method.
But, since we have plans to change the behavior of taking livechat inquiries, it's possible that storing the first message will not be necessary anymore.

@sampaiodiego sampaiodiego merged commit bec1008 into develop Apr 2, 2019
@sampaiodiego sampaiodiego deleted the livechat-get-first-room-message branch April 2, 2019 01:18
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego requested changes

@tassoevan tassoevan tassoevan left review comments

Assignees
No one assigned
Labels
squad: omnichannel subj: livechat
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

When clicking on incoming livechat, message is blank
5 participants
@renatobecker-zz @tassoevan @sampaiodiego @engelgabriel @renatobecker