Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements to federation callbacks/hooks #13946

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Small improvements to federation callbacks/hooks #13946

merged 3 commits into from
Mar 29, 2019

Conversation

sampaiodiego
Copy link
Member

  • Fix callback/hooks names
  • Add return values to callbacks on "success" flow (not only when skipped)
  • Doesn't check for federated users in all members of room when a new user is added, instead check if the new user is federated

@sampaiodiego sampaiodiego added this to the 1.0.0 milestone Mar 29, 2019
@sampaiodiego sampaiodiego requested a review from alansikora March 29, 2019 14:25
@sampaiodiego sampaiodiego merged commit c470673 into develop Mar 29, 2019
@sampaiodiego sampaiodiego deleted the improve-federation-hooks branch March 29, 2019 15:34
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alansikora alansikora alansikora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sampaiodiego @alansikora @engelgabriel