Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent error on normalize thread message for preview #14170

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Prevent error on normalize thread message for preview #14170

merged 1 commit into from
Apr 17, 2019

Conversation

tassoevan
Copy link
Contributor

When a thread message has no msg and all its attachments have neither title nor description, the preview fails.

@tassoevan tassoevan added this to the 1.0.0 milestone Apr 17, 2019
@tassoevan tassoevan requested a review from sampaiodiego April 17, 2019 13:45
sampaiodiego
sampaiodiego approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reproduce the error, but the check is welcome anyways =)

@sampaiodiego sampaiodiego merged commit c46c81f into develop Apr 17, 2019
@sampaiodiego sampaiodiego deleted the fix/normalize-thread-message branch April 17, 2019 18:28
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
feat: threads / discussions Threads and Discussions type: bug ui/ux
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tassoevan @sampaiodiego @engelgabriel